fix(helper/cookie): make default Path=/ for setCookie()/setSignedCookie()
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @usualoma Can you review this? |
|
In this PR, I've rewrite some tests but, the behavior of |
yusukebe
force-pushed
the
fix/cookie-default-path
branch
from
2011aa3
to
f439000
Compare
|
Yes, I believe this is the expected result of You should probably apply |
Ah! Thanks! |
yusukebe
changed the title
Path=/ for getCookie()/setSignedCookie()Path=/ for setCookie()/setSignedCookie()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1741
Author should do the followings, if applicable
yarn denoifyto generate files for Deno